HyukjinKwon commented on a change in pull request #22755:
[SPARK-25755][SQL][Test] Supplementation of non-CodeGen unit tested for
BroadcastHashJoinExec
URL: https://github.com/apache/spark/pull/22755#discussion_r244116852
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala
##########
@@ -65,6 +66,20 @@ private[sql] trait SQLTestUtils extends SparkFunSuite with
SQLTestUtilsBase with
}
}
+ /**
+ * A helper function for turning off/on codegen.
+ */
+ protected def testWithWholeStageCodegenOnAndOff(testName: String)(f: String
=> Unit): Unit = {
Review comment:
not a big deal at all but just wanted to say. Looks we could just `f: () =>
Unit`. `codegenEnabled` as an argument is used at two places.
One place is just for clue and it can be removed since test name already
describes if whole stage codegen is off or not.
The other place looks it needs but I think we can get read it from sql conf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
