gengliangwang edited a comment on issue #23387: [SPARK-26447][SQL]Allow OrcColumnarBatchReader to return less partition columns URL: https://github.com/apache/spark/pull/23387#issuecomment-450133835 @cloud-fan @dongjoon-hyun Thanks a lot for the review. @dongjoon-hyun I tried adding a test case for the improvement. But the implementation seems too low level for constructing and initializing `OrcColumnarBatchReader`. This PR is mainly for Orc V2 migration, since the code context is a bit complex. I prefer to add test case for checking if the output row of Orc V2 reader is pruned. Is that OK to you?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
