maropu commented on a change in pull request #23390:
[SPARK-21351][SQL][followup] reuse the FixNullability rule
URL: https://github.com/apache/spark/pull/23390#discussion_r244258236
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UpdateNullabilityInOptimizerSuite.scala
##########
@@ -36,8 +37,8 @@ class UpdateNullabilityInAttributeReferencesSuite extends
PlanTest {
SimplifyConditionals,
SimplifyBinaryComparison,
SimplifyExtractValueOps) ::
- Batch("UpdateAttributeReferences", Once,
- UpdateNullabilityInAttributeReferences) :: Nil
+ Batch("UpdateNullability", Once,
+ UpdateNullability) :: Nil
}
test("update nullability in AttributeReference") {
Review comment:
nit: plz update the comment inside this test:
`UpdateNullabilityInAttributeReferences` -> `UpdateNullability`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
