dongjoon-hyun commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r244265930
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
##########
@@ -141,13 +141,11 @@ class HiveUDFSuite extends QueryTest with
TestHiveSingleton with SQLTestUtils {
}
test("SPARK-2693 udaf aggregates test") {
- checkAnswer(
- sql("SELECT percentile(key, 1) FROM src LIMIT 1"),
- sql("SELECT double(max(key)) FROM src"))
+ checkAnswer(sql("SELECT percentile(key, 1) FROM src LIMIT 1"),
+ sql("SELECT max(key) FROM src").collect().toSeq)
Review comment:
It seems to be a big behavior change in Spark testing.
So, this PR is going to enforce us to use explicit `collect().toSeq` for
`checkAnswer` in some cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
