cloud-fan commented on a change in pull request #23394:
[SPARK-26424][SQL][FOLLOWUP] Fix DateFormatClass/UnixTime codegen
URL: https://github.com/apache/spark/pull/23394#discussion_r244327433
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -571,7 +571,7 @@ case class DateFormatClass(left: Expression, right:
Expression, timeZoneId: Opti
val tz = ctx.addReferenceObj("timeZone", timeZone)
val locale = ctx.addReferenceObj("locale", Locale.US)
defineCodeGen(ctx, ev, (timestamp, format) => {
- s"""UTF8String.fromString($tf.apply($format.toString(), $tz, $locale)
+ s"""UTF8String.fromString($tf$$.MODULE$$.apply($format.toString(), $tz,
$locale)
Review comment:
is `apply` a special case? IIRC java can call methods in scala object, just
like calling static methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
