hvanhovell commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r244420159
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -102,8 +102,8 @@ object ExtractEquiJoinKeys extends Logging with
PredicateHelper {
type ReturnType =
(JoinType, Seq[Expression], Seq[Expression], Option[Expression],
LogicalPlan, LogicalPlan)
- def unapply(plan: LogicalPlan): Option[ReturnType] = plan match {
- case join @ Join(left, right, joinType, condition) =>
+ def unapply(join: Join): Option[ReturnType] = join match {
+ case Join(left, right, joinType, condition) =>
Review comment:
That pattern match has sort of lost its purpose right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
