hvanhovell commented on a change in pull request #23391: [SPARK-26456][SQL]
Cast date/timestamp to string by Date/TimestampFormatter
URL: https://github.com/apache/spark/pull/23391#discussion_r244426510
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -111,6 +110,9 @@ class QueryExecution(
protected def stringOrError[A](f: => A): String =
try f.toString catch { case e: AnalysisException => e.toString }
+ private val dateFormatter = DateFormatter()
Review comment:
Yes please. We should just move that into the a test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
