dongjoon-hyun commented on a change in pull request #23395: [SPARK-26470][CORE]
Use ConfigEntry for hardcoded configs for eventLog category
URL: https://github.com/apache/spark/pull/23395#discussion_r244507988
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -82,8 +83,8 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
.set("spark.history.fs.update.interval", "0")
.set("spark.testing", "true")
.set(LOCAL_STORE_DIR, storeDir.getAbsolutePath())
- .set("spark.eventLog.logStageExecutorMetrics.enabled", "true")
- .set("spark.eventLog.logStageExecutorProcessTreeMetrics.enabled", "true")
+ .set(EVENT_LOG_STAGE_EXECUTOR_METRICS.key, "true")
+ .set(EVENT_LOG_PROCESS_TREE_METRICS.key, "true")
Review comment:
@mgaido91 . Sorry for nit-picking, but can we use a shorter form here and
the below?
```scala
- .set(EVENT_LOG_STAGE_EXECUTOR_METRICS.key, "true")
+ .set(EVENT_LOG_STAGE_EXECUTOR_METRICS, true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
