kiszk commented on a change in pull request #23412: [SPARK-26477][CORE] Use
ConfigEntry for hardcoded configs for unsafe category
URL: https://github.com/apache/spark/pull/23412#discussion_r244537777
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -715,6 +716,26 @@ package object config {
.checkValue(v => v > 0, "The max failures should be a positive value.")
.createWithDefault(40)
+ private[spark] val UNSAFE_EXCEPTION_ON_MEMORY_LEAK =
+ ConfigBuilder("spark.unsafe.exceptionOnMemoryLeak")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val UNSAFE_OFFHEAP =
+ ConfigBuilder("spark.unsafe.offHeap")
Review comment:
I am neutral on whether we create a new entry for an old name if the old
name is used.
I would like to hear other opinions. It would be good to have common opinion.
cc @ueshin @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
