hvanhovell commented on a change in pull request #23406: [SPARK-26504][SQL]
Rope-wise dumping of Spark plans
URL: https://github.com/apache/spark/pull/23406#discussion_r244540615
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -87,4 +89,35 @@ object StringUtils {
}
funcNames.toSeq
}
+
+ /**
+ * Concatenation of sequence of strings to final string with cheap append
method
Review comment:
I am wondering if `StringConcatenation` is a better name for this class, as
this class is technically a rope (that is a binary tree).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]