srowen commented on a change in pull request #23420: [SPARK-26508][Core][SQL]
Address warning messages in Java reported at lgtm.com
URL: https://github.com/apache/spark/pull/23420#discussion_r244590940
##########
File path: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java
##########
@@ -320,7 +320,7 @@ protected void handle(Message msg) throws IOException {
} else {
if (handle == null) {
throw new IllegalArgumentException("Expected hello, got: " +
- msg != null ? msg.getClass().getName() : null);
+ (msg != null ? msg.getClass().getName() : "null"));
Review comment:
You could probably just improve this by creating this class name string once
above line 321, and putting something like "no message" instead of null, while
we're here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
