Github user ryan-williams commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3467#discussion_r21033419
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -30,8 +30,12 @@ private[spark] class HistoryPage(parent: HistoryServer) 
extends WebUIPage("") {
       def render(request: HttpServletRequest): Seq[Node] = {
         val requestedPage = 
Option(request.getParameter("page")).getOrElse("1").toInt
         val requestedFirst = (requestedPage - 1) * pageSize
    +    val requestedIncomplete =
    +      
Option(request.getParameter("showIncomplete")).getOrElse("false").toBoolean
     
    -    val allApps = parent.getApplicationList()
    +    val allApps = parent.getApplicationList().filter( app =>
    +      (!requestedIncomplete && !app.incomplete) || (requestedIncomplete && 
app.incomplete)
    --- End diff --
    
    `requestedIncomplete == app.incomplete` might be simpler


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to