HyukjinKwon commented on a change in pull request #23417:
[SPARK-26374][TEST][SQL] Enable TimestampFormatter in HadoopFsRelationTest
URL: https://github.com/apache/spark/pull/23417#discussion_r244626242
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
##########
@@ -126,61 +126,60 @@ abstract class HadoopFsRelationTest extends QueryTest
with SQLTestUtils with Tes
} else {
Seq(false)
}
- // TODO: Support new parser too, see SPARK-26374.
- withSQLConf(SQLConf.LEGACY_TIME_PARSER_ENABLED.key -> "true") {
Review comment:
Can we leave this `withSQLConf(SQLConf.LEGACY_TIME_PARSER_ENABLED.key ->
"false") {`? That's going to clearly show the diff and technically this
configuration isn't removed yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
