srowen commented on a change in pull request #23419: [SPARK-26507][CORE] Fix
core tests for Java 11
URL: https://github.com/apache/spark/pull/23419#discussion_r244610615
##########
File path: pom.xml
##########
@@ -2113,7 +2115,7 @@
<include>**/*Suite.java</include>
</includes>
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
- <argLine>-ea -Xmx3g -Xss4m
-XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
+ <argLine>-ea -Xmx6g -Xss4m
-XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
Review comment:
The TimSort test failed, where it allocates a very very large array.
I'm pretty sure it's because we can't get around the off-heap allocation
limits in Java 9+ (see https://github.com/apache/spark/pull/22993/files). I
think this would also pass if we manually set the off-heap limit very high, or
allowed access to the `Cleaner` class on the command line. Upping the memory
seemed like a simpler workaround but those should be fine too.
EDIT: I don't think this is right. See
https://github.com/apache/spark/pull/23419#issuecomment-450772125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
