cloud-fan commented on a change in pull request #23391: [SPARK-26456][SQL] Cast
date/timestamp to string by Date/TimestampFormatter
URL: https://github.com/apache/spark/pull/23391#discussion_r244655731
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
##########
@@ -230,7 +235,7 @@ object PartitioningUtils {
// Once we get the string, we try to parse it and find the partition
column and value.
val maybeColumn =
parsePartitionColumn(currentPath.getName, typeInference,
userSpecifiedDataTypes,
- validatePartitionColumns, timeZone)
+ validatePartitionColumns, timeZone, dateFormatter,
timestampFormatter)
Review comment:
then shall we update the migration guide about the difference? I think the
changes here is better as SQL standard uses Gregorian calendar.
IIUC, the behavior difference only happens when reading files? If users
write a timestamp literal and display it, we should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
