gatorsmile commented on a change in pull request #23276: [SPARK-26321][SQL]
Split a SQL in correct way
URL: https://github.com/apache/spark/pull/23276#discussion_r244659631
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala
##########
@@ -43,4 +43,70 @@ class StringUtilsSuite extends SparkFunSuite {
assert(filterPattern(names, " a. ") === Seq("a1", "a2"))
assert(filterPattern(names, " d* ") === Nil)
}
+
+ test("split a SQL") {
Review comment:
The test case coverage is still not enough. For example, adding some test
cases from
https://github.com/apache/hive/commit/65a65826a0d351a3d918bdb98595bdd106d37adb#diff-6182a9d1d63c707dff0ecd4e6a025fd2
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
