srowen commented on a change in pull request #23417: [SPARK-26374][TEST][SQL]
Enable TimestampFormatter in HadoopFsRelationTest
URL: https://github.com/apache/spark/pull/23417#discussion_r244865188
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
##########
@@ -138,7 +137,8 @@ abstract class HadoopFsRelationTest extends QueryTest with
SQLTestUtils with Tes
logInfo(s"Testing $dataType data type$extraMessage")
val extraOptions = Map[String, String](
- "parquet.enable.dictionary" ->
parquetDictionaryEncodingEnabled.toString
+ "parquet.enable.dictionary" ->
parquetDictionaryEncodingEnabled.toString,
+ "timestampFormat" -> "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX"
Review comment:
Yeah this is a complicated issue. But I think one takeaway is that old dates
weren't actually being written correctly before. Without the seconds on the
timezone, the first date can't be read back correctly as that info is lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
