MaxGekk commented on issue #23000: [SPARK-26002][SQL] Fix day of year calculation for Julian calendar days URL: https://github.com/apache/spark/pull/23000#issuecomment-451002405 > correcting the dayOfYear/month/year operators as the result in the following example are very strange ... I see, we still use hybrid calendar in casting `UTF8String` to timestamps. An alternative solution could be rewriting this code: https://github.com/apache/spark/blob/7c7fccfeb5bc079fede41eb64f57ab6b1b4b9018/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L414-L430 by using java.time API based on Proleptic Gregorian Calendar but such changes look like more heavy. I would guess they will be done to follow SQL standard in the end, so, your fix for Julian calendar will be not needed. At the moment, I agree we need your fix to handle results from `stringToTimestamp` properly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
