jerryshao commented on a change in pull request #23401: [SPARK-26513][Core] :
Trigger GC on executor node idle
URL: https://github.com/apache/spark/pull/23401#discussion_r244902691
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -628,6 +630,22 @@ private[spark] class Executor(
}
} finally {
runningTasks.remove(taskId)
+ if(idleGCEnabled) {
+ if (runningTasks.isEmpty) {
Review comment:
Is this enough to check whether executor is idle or not? I'm afraid the
follow-up stages will come soon, but due to the full-gc, it makes the current
executors unavailable.
There're plenty of ways to trigger GC manually if you do think this is
proper/idle time for executor to do full-gc, like jconsole, jvisualvm. Also
real-world workloads are quite different. IMHO putting this mechanism in
executor automatically seems a little strange to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
