Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3515#discussion_r21055836
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -401,7 +370,7 @@ class DAGScheduler(
val s = stages.head
s.jobIds += jobId
jobIdToStageIds.getOrElseUpdate(jobId, new HashSet[Int]()) += s.id
- val parents: List[Stage] = getParentStages(s.rdd, jobId)
--- End diff --
It might look like this changes the behavior of this method, since
`getParentStages` will create any parent stages that are missing. However, I
think that this call never ended up taking the "create a missing stage" branch
because `stage`'s parent stages should have already been created before it was
created, since `getParentStages(stage.rdd, jobId)` should have been called from
the `newStage` method:
https://github.com/JoshRosen/spark/blob/dagscheduler-missingparents-cleanup/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
