SandishKumarHN commented on a change in pull request #23401:
[SPARK-26513][Core] : Trigger GC on executor node idle
URL: https://github.com/apache/spark/pull/23401#discussion_r244906556
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -628,6 +630,22 @@ private[spark] class Executor(
}
} finally {
runningTasks.remove(taskId)
+ if(idleGCEnabled) {
+ if (runningTasks.isEmpty) {
Review comment:
Will only call GC when heap usage is more than 70 or 80% used. heap gets
cleared only when context cleaner run's full GC(which run's for every 30
minutes). in between the executor is idle, why don't we use that time for GC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]