squito commented on a change in pull request #23337: [SPARK-26019][PYSPARK]
Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r244909426
##########
File path: python/pyspark/tests.py
##########
@@ -2381,6 +2382,34 @@ def test_startTime(self):
with SparkContext() as sc:
self.assertGreater(sc.startTime, 0)
+ def test_forbid_insecure_gateway(self):
+ # By default, we fail immediately if you try to create a SparkContext
+ # with an insecure gateway
+ gateway = _launch_gateway(insecure=True)
+ with self.assertRaises(Exception) as context:
+ SparkContext(gateway=gateway)
+ self.assertIn("insecure py4j gateway", context.exception.message)
+ self.assertIn("spark.python.allowInsecurePy4j",
context.exception.message)
+ self.assertIn("removed in Spark 3.0", context.exception.message)
+
+ def test_allow_insecure_gateway_with_conf(self):
+ with SparkContext._lock:
+ SparkContext._gateway = None
+ SparkContext._jvm = None
Review comment:
ok its good to get some confirmation of this weird behavior ... but I feel
like I still don't understand why we don't reset `SparkContext._gateway` and
`SparkContext._jvm` in `sc.stop()`; and why when I tried to make that change, I
hit all those errors. if nothing else, any chance this is related to general
flakiness in pyspark tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
