hvanhovell commented on a change in pull request #23392: [SPARK-26450][SQL]
Avoid rebuilding map of schema for every column in projection
URL: https://github.com/apache/spark/pull/23392#discussion_r244961264
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##########
@@ -88,7 +88,9 @@ package object expressions {
/**
* A helper function to bind given expressions to an input schema.
*/
- def toBoundExprs(exprs: Seq[Expression], inputSchema: Seq[Attribute]):
Seq[Expression] = {
+ def toBoundExprs[A <: Expression](
Review comment:
I would like to minimize the chance that future changes suffer from the same
issue. In order to do that we should provide API in a logical place, it does
not make a whole lot of sense to me that I need to look in `package.scala` to
find a more performant version of `BindReferences.bindReference(..)` for a seq.
Can we move this function to `BindReference` and name it `bindReferences`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
