sujith71955 commented on issue #23429: [WIP][SPARK-26432][CORE] Obtain HBase delegation token operation compatible with HBase 2.x.x version API URL: https://github.com/apache/spark/pull/23429#issuecomment-451239600 > Does your code keep support for HBase 1.x? Looks like it does not; that's the main reason why I just didn't submit my patch for this: > [cloudera/spark@3de80e4#diff-6e15cee083da1fefc4b9fa8a1f8642e9](https://github.com/cloudera/spark/commit/3de80e469211797a099798e8bbe2b1fba74ff3df#diff-6e15cee083da1fefc4b9fa8a1f8642e9) > > It should be easy to keep both by just keeping the existing code in a different method, then calling that one if the 2.x method fails. > > Also, please use the PR title to explain the solution, not the problem. Problems are described in the bug, not the PR. Will update based on your comment. Thanks for the valuable feedback.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
