vanzin commented on a change in pull request #23338: [SPARK-25689][yarn] Make
driver, not AM, manage delegation tokens.
URL: https://github.com/apache/spark/pull/23338#discussion_r245123590
##########
File path:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
##########
@@ -85,60 +76,44 @@ private[spark] class HadoopDelegationTokenManager(
s"${delegationTokenProviders.keys.mkString(", ")}.")
private var renewalExecutor: ScheduledExecutorService = _
- private val driverRef = new AtomicReference[RpcEndpointRef]()
-
- /** Set the endpoint used to send tokens to the driver. */
- def setDriverRef(ref: RpcEndpointRef): Unit = {
- driverRef.set(ref)
- }
/** @return Whether delegation token renewal is enabled. */
def renewalEnabled: Boolean = principal != null
/**
- * Start the token renewer. Requires a principal and keytab. Upon start, the
renewer will:
+ * Start the token renewer. Requires a principal and keytab. Upon start, the
renewer will
+ * obtain delegation tokens for all configured services and send them to the
driver, and
+ * set up tasks to periodically get fresh tokens as needed.
*
- * - log in the configured principal, and set up a task to keep that user's
ticket renewed
- * - obtain delegation tokens from all available providers
- * - send the tokens to the driver, if it's already registered
- * - schedule a periodic task to update the tokens when needed.
+ * If the logged in user has a keytab, this method will also try to keep
that user's TGT
Review comment:
Ah, didn't notice this was the start() method; yes, currently that requires
a keytab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
