vanzin commented on a change in pull request #23442: [MINOR][NETWORK][TEST] Fix
TransportFrameDecoderSuite to use ByteBuf instead of ByteBuffer
URL: https://github.com/apache/spark/pull/23442#discussion_r245161714
##########
File path:
common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java
##########
@@ -69,7 +68,7 @@ public void testInterception() throws Exception {
decoder.channelRead(ctx, len);
decoder.channelRead(ctx, dataBuf);
verify(interceptor, times(interceptedReads)).handle(any(ByteBuf.class));
- verify(ctx).fireChannelRead(any(ByteBuffer.class));
+ verify(ctx).fireChannelRead(any(ByteBuf.class));
Review comment:
I was trying to figure out why this even compiled (the class doesn't really
make a difference here otherwise, since it's an `any` matcher). The API is
actually `fireChannelRead(Object msg)`, which explains it.
Anyway, the change is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
