srowen commented on issue #23411: [SPARK-26503][CORE] Get rid of spark.sql.legacy.timeParser.enabled URL: https://github.com/apache/spark/pull/23411#issuecomment-451326297 @MaxGekk I ran it locally with Java 8: ``` # VM version: JDK 1.8.0_192, Java HotSpot(TM) 64-Bit Server VM, 25.192-b12 ... Benchmark Mode Cnt Score Error Units DateParsingBenchmark.newFormat_noZone avgt 5 51.168 ± 0.398 ms/op DateParsingBenchmark.newFormat_withZone avgt 5 1375.479 ± 8.168 ms/op DateParsingBenchmark.oldFormat_noZone avgt 5 76.494 ± 0.662 ms/op DateParsingBenchmark.oldFormat_withZone avgt 5 84.934 ± 1.238 ms/op ``` and Java 11: ``` # VM version: JDK 11.0.1, OpenJDK 64-Bit Server VM, 11.0.1+13 ... Benchmark Mode Cnt Score Error Units DateParsingBenchmark.newFormat_noZone avgt 5 48.196 ± 0.446 ms/op DateParsingBenchmark.newFormat_withZone avgt 5 84.605 ± 1.056 ms/op DateParsingBenchmark.oldFormat_noZone avgt 5 84.288 ± 0.911 ms/op DateParsingBenchmark.oldFormat_withZone avgt 5 98.591 ± 0.602 ms/op ``` Still a big difference unfortunately. I'd say let's leave in the old parser for the foreseeable future, at least.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
