HyukjinKwon commented on a change in pull request #23444: [SPARK-26529]Add logs
for IOException when preparing local resource
URL: https://github.com/apache/spark/pull/23444#discussion_r245261862
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -780,10 +780,19 @@ private[spark] class Client(
props.store(writer, "Spark configuration.")
writer.flush()
confStream.closeEntry()
+ confArchive
+ } catch {
+ case e: IOException =>
+ logError(s"IOException occurred while writing to confArchive
$confArchive", e)
+ throw e
Review comment:
I meant, I think I wouldn't list more exceptions when similar case happens.
For instance, current code only handles with `IOException`. If other exceptions
can be raised again, we should add it again. It sounds not quite reasonable.
So, I would rather do, for instance, `logDebug("Creating an archive with the
config files for distribution at $confArchive.")` in the main code without
try/catch exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
