cloud-fan commented on a change in pull request #23383: [SPARK-23817][SQL]
Migrate ORC file format read path to data source V2
URL: https://github.com/apache/spark/pull/23383#discussion_r245277503
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -85,19 +85,24 @@ private[sql] object OrcFilters {
// First, tries to convert each filter individually to see whether it's
convertible, and then
// collect all convertible ones to build the final `SearchArgument`.
- val convertibleFilters = for {
- filter <- filters
- _ <- buildSearchArgument(dataTypeMap, filter, newBuilder)
- } yield filter
+ val convertible = convertibleFilters(schema, filters)
Review comment:
`convertible` -> `filters`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
