vanzin commented on a change in pull request #23413: [SPARK-26491][CORE][TEST]
Use ConfigEntry for hardcoded configs for test categories
URL: https://github.com/apache/spark/pull/23413#discussion_r245396460
##########
File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
##########
@@ -126,8 +127,8 @@ object SizeEstimator extends Logging {
private def getIsCompressedOops: Boolean = {
// This is only used by tests to override the detection of compressed
oops. The test
Review comment:
I didn't mean it's useless (it might be, didn't look), just that it could be
kept as a system property instead of a config constant (since it's never set in
or read from SparkConf). Using a string constant sounds fine, but given what I
think is the goal of these changes (see SPARK-26060), that wouldn't really
change much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
