mgaido91 commented on a change in pull request #23413:
[SPARK-26491][CORE][TEST] Use ConfigEntry for hardcoded configs for test
categories
URL: https://github.com/apache/spark/pull/23413#discussion_r245404158
##########
File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
##########
@@ -126,8 +127,8 @@ object SizeEstimator extends Logging {
private def getIsCompressedOops: Boolean = {
// This is only used by tests to override the detection of compressed
oops. The test
Review comment:
the point is: it is set in `SparkConf` in some tests. But this is probably
useless because we read it only here as a system property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
