Ngone51 commented on a change in pull request #22806: [SPARK-25250][CORE] :
Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r245463532
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -1096,6 +1096,11 @@ private[spark] class TaskSetManager(
def executorAdded() {
recomputeLocality()
}
+
+ def markPartitionIdAsCompletedForTaskAttempt(index: Int): Unit = {
Review comment:
Also, I think we need to increase `tasksSuccessful` and mark this
`TaskSetManager` as zombie if its successful tasks num has reached `numTasks`.
You can refer to `markPartitionCompleted()` for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
