xy2953396112 commented on a change in pull request #23455:
[SPARK-26246][SQL][FOLLOWUP] Inferring TimestampType from JSON
URL: https://github.com/apache/spark/pull/23455#discussion_r245474352
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -117,6 +117,12 @@ private[sql] class JSONOptions(
*/
val pretty: Boolean =
parameters.get("pretty").map(_.toBoolean).getOrElse(false)
+ /**
+ * Enables inferring of TimestampType from strings matched to the timestamp
pattern
+ * defined by the timestampFormat option.
+ */
+ val inferTimestamp: Boolean =
parameters.get("inferTimestamp").map(_.toBoolean).getOrElse(true)
Review comment:
rename inferTimestamp for inferTimestampType ?
```suggestion
val inferTimestampType: Boolean =
parameters.get("inferTimestamp").map(_.toBoolean).getOrElse(true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
