MaxGekk commented on a change in pull request #23455:
[SPARK-26246][SQL][FOLLOWUP] Inferring TimestampType from JSON
URL: https://github.com/apache/spark/pull/23455#discussion_r245475071
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -117,6 +117,12 @@ private[sql] class JSONOptions(
*/
val pretty: Boolean =
parameters.get("pretty").map(_.toBoolean).getOrElse(false)
+ /**
+ * Enables inferring of TimestampType from strings matched to the timestamp
pattern
+ * defined by the timestampFormat option.
+ */
+ val inferTimestamp: Boolean =
parameters.get("inferTimestamp").map(_.toBoolean).getOrElse(true)
Review comment:
I would add the `Type` suffix if there is an alternative of what else can be
inferred besides of a type. We already have JSON options like `prefersDecimal`
and `primitivesAsString` that suppose types in their names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
