HyukjinKwon commented on a change in pull request #23464: [SPARK-26383][Core] -
NPE when use DataFrameReader.jdbc with wrong URL
URL: https://github.com/apache/spark/pull/23464#discussion_r245478938
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -68,7 +68,9 @@ object JDBCRDD extends Logging {
statement.close()
}
} finally {
- conn.close()
+ if (null != conn) {
+ conn.close()
+ }
Review comment:
`createConnectionFactory` is called in multiple place. Can you throw an
exception when `conn` is `null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
