srowen commented on a change in pull request #23463:
[SPARK-26536][BUILD][FOLLOWUP][test-maven] Make StreamingReadSupport public for
maven testing
URL: https://github.com/apache/spark/pull/23463#discussion_r245510916
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java
##########
@@ -20,11 +20,10 @@
import org.apache.spark.sql.sources.v2.reader.ReadSupport;
/**
- * A base interface for streaming read support. This is package private and is
invisible to data
- * sources. Data sources should implement concrete streaming read support
interfaces:
- * {@link MicroBatchReadSupport} or {@link ContinuousReadSupport}.
+ * A base interface for streaming read support. Data sources should implement
concrete streaming
+ * read support interfaces: {@link MicroBatchReadSupport} or {@link
ContinuousReadSupport}.
*/
-interface StreamingReadSupport extends ReadSupport {
+public interface StreamingReadSupport extends ReadSupport {
Review comment:
That's weird; the access is coming from the same package. I wonder why it
generates IllegalAccessError? Is there any other way to work around it, like
placing some public subinterface in the test source tree that mockito can
access?
We have used `@VisibleForTesting` elsewhere to annotate things that are only
public for test purposes, FWIW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
