srowen commented on a change in pull request #23448: [SPARK-26126]Put 
scala-library deps into root pom
URL: https://github.com/apache/spark/pull/23448#discussion_r245511527
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -273,6 +273,11 @@
       <artifactId>unused</artifactId>
       <version>1.0.0</version>
     </dependency>
+    <dependency>
 
 Review comment:
   No, generally speaking the parent POM does not declare dependencies (there 
are some odd exceptions here). The actual modules declare dependencies, and not 
every single one needs scala-library I think. The other modules already declare 
a dependency on scala-library, like core; tags isn't how they get it. what is 
the problem that you're solving?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to