imatiach-msft commented on a change in pull request #21632:
[SPARK-19591][ML][MLlib] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/21632#discussion_r245517909
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala
##########
@@ -23,6 +23,7 @@ import scala.util.Try
import org.apache.spark.annotation.Since
import org.apache.spark.api.java.JavaRDD
import org.apache.spark.internal.Logging
+import org.apache.spark.ml.feature.{Instance => NewInstance}
Review comment:
I think it is just following the pattern of the rest of the code, all of the
ML-related (as opposed to MLLIB) is renamed, for example see:
import org.apache.spark.ml.tree.{DecisionTreeModel => NewDTModel,
TreeEnsembleParams => NewRFParams}
import org.apache.spark.ml.tree.impl.{RandomForest => NewRandomForest}
This isn't a deal-breaker for me though so I've renamed it back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
