srowen commented on a change in pull request #23476: [SPARK-26554][BUILD]
Update `release-util.sh` to avoid GitBox fake 200 headers
URL: https://github.com/apache/spark/pull/23476#discussion_r245527596
##########
File path: dev/create-release/release-util.sh
##########
@@ -73,7 +73,7 @@ function fcreate_secure {
}
function check_for_tag {
- curl -s --head --fail "$ASF_REPO_WEBUI;a=commit;h=$1" >/dev/null
+ ! curl -s --fail "$ASF_REPO_WEBUI;a=commit;h=$1" | grep '404 Not Found' >
/dev/null
Review comment:
What does the `!` do -- make this fail if grep successfully found a 404?
does `grep -v` get the same effect? No need to change it, it's fine, just
curious
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
