HeartSaVioR commented on a change in pull request #23423: [SPARK-26482][CORE]
Use ConfigEntry for hardcoded configs for ui categories
URL: https://github.com/apache/spark/pull/23423#discussion_r245530908
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -304,11 +305,10 @@ object HistoryServer extends Logging {
config.set(SecurityManager.SPARK_AUTH_CONF, "false")
}
- if (config.getBoolean("spark.acls.enable",
config.getBoolean("spark.ui.acls.enable", false))) {
- logInfo("Either spark.acls.enable or spark.ui.acls.enable is configured,
clearing it and " +
- "only using spark.history.ui.acl.enable")
- config.set("spark.acls.enable", "false")
- config.set("spark.ui.acls.enable", "false")
+ if (config.get(ACLS_ENABLE)) {
+ logInfo(s"${ACLS_ENABLE.key} is configured, " +
+ s"clearing it and only using
${History.HISTORY_SERVER_UI_ACLS_ENABLE.key}")
+ config.set(ACLS_ENABLE.key, "false")
Review comment:
Nice finding! Will address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
