Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3526#discussion_r21076063
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
 ---
    @@ -298,11 +298,15 @@ case class InsertIntoParquetTable(
           val committer = format.getOutputCommitter(hadoopContext)
           committer.setupTask(hadoopContext)
           val writer = format.getRecordWriter(hadoopContext)
    -      while (iter.hasNext) {
    -        val row = iter.next()
    -        writer.write(null, row)
    +      try {
    +        while (iter.hasNext) {
    +          val row = iter.next()
    +          writer.write(null, row)
    +        }
    +      }
    +      finally {
    --- End diff --
    
    can you put the finally on the same line as the previous } ? thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to