cloud-fan commented on a change in pull request #22806: [SPARK-25250][CORE] :
Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r245568882
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala
##########
@@ -109,4 +109,7 @@ private[spark] trait TaskScheduler {
*/
def applicationAttemptId(): Option[String]
+ def markPartitionIdAsCompletedAndKillCorrespondingTaskAttempts(
Review comment:
We already have `submitTasks`, `cancelTasks`, `killTaskAttempt` etc. in this
class, how about renaming this method to `completeTasks`? And add comment to
explain what this method does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
