ueshin commented on a change in pull request #23416: [SPARK-26463][CORE] Use
ConfigEntry for hardcoded configs for scheduler categories.
URL: https://github.com/apache/spark/pull/23416#discussion_r245568636
##########
File path:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
##########
@@ -457,9 +458,9 @@ class StandaloneDynamicAllocationSuite
test("initial executor limit") {
val initialExecutorLimit = 1
val myConf = appConf
- .set("spark.dynamicAllocation.enabled", "true")
- .set(config.SHUFFLE_SERVICE_ENABLED.key, "true")
- .set("spark.dynamicAllocation.initialExecutors",
initialExecutorLimit.toString)
+ .set(DYN_ALLOCATION_ENABLED, true)
+ .set(SHUFFLE_SERVICE_ENABLED, true)
+ .set(DYN_ALLOCATION_INITIAL_EXECUTORS, initialExecutorLimit)
Review comment:
Shall we use `config.` prefix here instead of import `config._` just for
these?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
