maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r245728150
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -350,6 +351,17 @@ case class Join(
case UsingJoin(_, _) => false
case _ => resolvedExceptNatural
}
+
+ // Ignore hint for canonicalization
+ protected override def doCanonicalize(): LogicalPlan =
+ super.doCanonicalize().asInstanceOf[Join].copy(hint = JoinHint.NONE)
+
+ // Do not include an empty join hint in string description
+ protected override def stringArgs: Iterator[Any] = super.stringArgs.filter {
e =>
Review comment:
I was trying to do it in a way that would be "extendable", say, it would
work with any future change of the constructor (although we don't expect the
constructor of logical operators to change much).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
