pralabhkumar commented on a change in pull request #23447: [SPARK-26462][CORE]
Use ConfigEntry for hardcoded configs for execution categories
URL: https://github.com/apache/spark/pull/23447#discussion_r245732955
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -60,15 +61,15 @@ class BlockManagerMasterEndpoint(
private val topologyMapper = {
val topologyMapperClassName = conf.get(
- "spark.storage.replication.topologyMapper",
classOf[DefaultTopologyMapper].getName)
+ config.STORAGE_REPLICATION_TOPOLOGY_MAPPER)
val clazz = Utils.classForName(topologyMapperClassName)
val mapper =
clazz.getConstructor(classOf[SparkConf]).newInstance(conf).asInstanceOf[TopologyMapper]
logInfo(s"Using $topologyMapperClassName for getting topology information")
mapper
}
- val proactivelyReplicate = conf.get("spark.storage.replication.proactive",
"false").toBoolean
+ val proactivelyReplicate = conf.get(STORAGE_REPLICATION_PROACTIVE)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
