gatorsmile commented on a change in pull request #23401: [SPARK-26513][Core] :
Trigger GC on executor node idle
URL: https://github.com/apache/spark/pull/23401#discussion_r245843791
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -628,6 +630,22 @@ private[spark] class Executor(
}
} finally {
runningTasks.remove(taskId)
+ if(idleGCEnabled) {
+ if (runningTasks.isEmpty) {
Review comment:
Yes. See the paper.
https://people.eecs.berkeley.edu/~maas/papers/maas-asplos16-taurus.pdf A
holistic GC is better; otherwise, let Spark end users do it, like what I
suggested above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
