cloud-fan commented on a change in pull request #23489: [SPARK-26565][BUILD] remove pgp signing and svn publish for packaging URL: https://github.com/apache/spark/pull/23489#discussion_r245858366
########## File path: dev/create-release/release-build.sh ########## @@ -181,10 +183,6 @@ if [[ "$1" == "package" ]]; then rm spark-$SPARK_VERSION/NOTICE-binary rm -r spark-$SPARK_VERSION/licenses-binary tar cvzf spark-$SPARK_VERSION.tgz spark-$SPARK_VERSION - echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour --output spark-$SPARK_VERSION.tgz.asc \ - --detach-sig spark-$SPARK_VERSION.tgz - echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --print-md \ - SHA512 spark-$SPARK_VERSION.tgz > spark-$SPARK_VERSION.tgz.sha512 Review comment: maybe a better idea is to make singing a separated phase. The `do-release.sh` should first call `release-build.sh package` to get the binary files, and call `release-build.sh sign` to sign them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
