coderplay commented on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections. URL: https://github.com/apache/spark/pull/20512#issuecomment-452178010 Clarification: I am not a spark expert, just got an invitation from @rxin because he think I have some knowledge about linux TCP. Generally, the patch looks good to me for the purpose of preventing inactivity from disconnecting the channel. But from the diff, looks like this commit will impact other RPCs or shuffling transport as well. It's not only for master RPCs as the title declared. The worst case for TCP keep alive is one message per client connection which probably is the case of data shuffling or some specific RPC types. If we maintain only one switch for ruling everything, the config will have negative impact on the performance in those cases. http://blog.catchpoint.com/2011/03/25/relying_on_web_performance_monitoring_to_discover_release_problems/ Min
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
