MaxGekk commented on a change in pull request #23460: [SPARK-26544][SQL] Escape 
string to keep alignment with hive
URL: https://github.com/apache/spark/pull/23460#discussion_r245960219
 
 

 ##########
 File path: sql/core/pom.xml
 ##########
 @@ -151,6 +151,10 @@
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>${hive.group}</groupId>
+      <artifactId>hive-exec</artifactId>
+    </dependency>
 
 Review comment:
   Main reason of `HiveResult` presents in `sql/core` is because it is used in 
`SQLQueryTestSuite`: 
https://github.com/apache/spark/blob/2a30deb85ae4e42c5cbc936383dd5c3970f4a74f/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L290
 If we get rid off using it in the tests, we can move it to `hive`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to