cloud-fan commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r245973381
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -724,17 +724,29 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
"type: GroupBy]"))
}
- test("SPARK-26021: Double and Float 0.0/-0.0 should be equal when grouping")
{
- val colName = "i"
- val doubles = Seq(0.0d, -0.0d,
0.0d).toDF(colName).groupBy(colName).count().collect()
- val floats = Seq(0.0f, -0.0f,
0.0f).toDF(colName).groupBy(colName).count().collect()
-
- assert(doubles.length == 1)
- assert(floats.length == 1)
- // using compare since 0.0 == -0.0 is true
- assert(java.lang.Double.compare(doubles(0).getDouble(0), 0.0d) == 0)
- assert(java.lang.Float.compare(floats(0).getFloat(0), 0.0f) == 0)
- assert(doubles(0).getLong(1) == 3)
- assert(floats(0).getLong(1) == 3)
+ test("SPARK-26021: NaN and -0.0 in grouping expressions") {
+ checkAnswer(
+ Seq(0.0f, -0.0f, 0.0f/0.0f, Float.NaN).toDF("f").groupBy("f").count(),
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
